App hassgraph: fix case of unknown values#2895
Closed
ChaosKid42 wants to merge 1 commit intotidbyt:mainfrom
Closed
App hassgraph: fix case of unknown values#2895ChaosKid42 wants to merge 1 commit intotidbyt:mainfrom
ChaosKid42 wants to merge 1 commit intotidbyt:mainfrom
Conversation
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
Contributor
|
@vincentezw Assuming this is cool to merge? Seems uncontroversial. |
Contributor
|
LGTM |
ChaosKid42
force-pushed
the
hassgraph_fix_unknown_values
branch
from
750f260 to
0603ddd
Compare
|
We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App HASS Graph:
This PR makes the App skip unknown values from HA.
@vincentezw : Hope you approve.